Fimeg/SouveraineOS
Watch
1
0
Fork
You've already forked SouveraineOS
 0
Code Releases Activity

docs: record SLIMbus review result

Browse source
This commit is contained in:
Casey Tunturi 2026-08-07 20:00:47 -04:00
commit bc0021463d
1 changed files with 23 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

31
docs/davids-tasks/slimbus-def-act-chan.md
View file

@ -1,18 +1,29 @@
# SLIMbus `DEF_ACT_CHAN` upstream follow-up
Status: waiting for David Heidelberg's review. Nothing has been sent upstream.
Status: David Heidelberg reviewed the prepared branch. His requested changes
are applied. Nothing has been sent upstream.
## Prepared work
- Original `linux-blueline` commit under review: `3ceab71eded0`
- Review branch: [`b4/slimbus-def-act-chan`](https://gitea.wiuf.net/Fimeg/linux-blueline/src/branch/b4/slimbus-def-act-chan)
- Prepared patch commit: `5f83f613b93d`
- Prepared patch commit: `2c1c6abf986a`
- [Prepared patch artifact](https://gitea.wiuf.net/Fimeg/Pixel3Arch/src/branch/main/upstream/standalone/slimbus-def-act-chan-v1/0001-slimbus-qcom-ngd-ctrl-match-downstream-def_act_chan-encoding.patch)
- Upstream base recorded by `b4`: `55f2ea9ff83c`
- Public identity: `Casey Tunturi <Casey@SamaritanSolutions.net>`
The address is verified and primary on Casey's `Fimeg` GitHub account.
## David's review
David asked for two changes:
1. Remove the explanatory comment above the encoding expression.
2. Add `phone-devel@vger.kernel.org` to the cover's Cc list.
Both are in the review branch. David said the patch looked ready to send, but
did not supply a formal `Reviewed-by:` or other trailer. That is not a blocker.
## What was verified
Qualcomm downstream encodes the first `DEF_ACT_CHAN` byte as:
@ -35,7 +46,10 @@ The history tag is:
Fixes: 52490169cddf ("slimbus: ngd: add stream support")
```
The prepared patch passed `checkpatch.pl` with no errors, warnings, or checks.
The patch has no `checkpatch.pl` style diagnostic. This vendor worktree lacks
`scripts/spelling.txt`, `scripts/const_structs.checkpatch`, and the upstream
history containing the `Fixes:` commit, so `b4 prep --check` also reports those
three local-tree limitations. They are not findings against the patch.
## Handling David's reply
@ -58,12 +72,12 @@ v1 rather than becoming v2.
Only continue when Casey asks.
1. Apply David's feedback and any exact tags he supplied.
2. Regenerate the saved patch and update the Gitea review branch.
3. Configure or authenticate `b4` for
1. If David sends further feedback or an exact tag, apply it and refresh the
saved patch and Gitea review branch.
2. Configure or authenticate `b4` for
`Casey@SamaritanSolutions.net`.
4. Run `b4 send --reflect` and inspect the copy delivered only to Casey.
5. After Casey explicitly approves the reflected message, run `b4 send`.
3. Run `b4 send --reflect` and inspect the copy delivered only to Casey.
4. After Casey explicitly approves the reflected message, run `b4 send`.
The prepared routing is:
@ -71,6 +85,7 @@ The prepared routing is:
- Cc: `linux-arm-msm@vger.kernel.org`
- Cc: `linux-sound@vger.kernel.org`
- Cc: `linux-kernel@vger.kernel.org`
- Cc: `phone-devel@vger.kernel.org`
- Cc: `stable@vger.kernel.org`
After submission: